Update tests #1192
Merged
Update tests #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profile tests auth tests testimony tests
common.ts moderations.test.ts moderationcompontents.test.tesx modifyAccount.test.ts testutils.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@sashamaryl is attempting to deploy a commit to the Maple Testimony Team on Vercel. A member of the Team first needs to authorize it. |
|
is this aero?? |
tommagnusson
requested changes
Jul 9, 2023
There was a problem hiding this comment.
Mostly minor tweaks, thanks for adding tests! I like how you factored out some common helpers within the tests.
I think most of my comments are around types and clarity. Sometimes it's a little tricky to make it clear to a reader what is actually being tested.
|
This is currently disabled. Will be a future part of our github flow. We could consider making "update tests" its own epic. Eventually, people will create their own tests as they create components/functions. |
…-maps into update-tests
addresses Tom's comments
addresses pr comments
fixes firestore rule for reading profile resource
cleans up imports
moves modifyAccount tests into moderation.tests file
…into update-tests-stash-recover
removes search tests from ci list
the indentation was causing the command to be parsed as separate lines, but they should be parsed as one long lnie
This fixes a permission error about firebase installations in local dev, where we don't need analytics anyway
This cleans up logs during tests
alexjball
approved these changes
Nov 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tests in the project with the goal of re-implementing CI integration tests
updated in this pr: